Don't crash on pauses longer than 10sec#93
Open
ngorogiannis wants to merge 2 commits into
Open
Conversation
ngorogiannis
force-pushed
the
refactor-common
branch
from
b4fb86a to
7bf3c73
Compare
ngorogiannis
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extract common code between 5.0 and 5.3 implementations. A modest reduction in code duplication. A more sophisticated refactor is possible at the cost of more complexity at the top levels.
Don't crash on pauses longer than 10sec. Done by adding a little bit of machinery to track such pauses and report some basic stats on them.
The main motivation is that it is possible, though not easily reproducible, to have pauses for more than 10sec (observed with workload described in #63 ). This crashes olly currently.